Skip to content

Start the contacts popup#145

Merged
nickvergessen merged 6 commits into
masterfrom
contacts-popup
Apr 27, 2017
Merged

Start the contacts popup#145
nickvergessen merged 6 commits into
masterfrom
contacts-popup

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Apr 27, 2017

Copy link
Copy Markdown
Member

@georgehrke can you help? the popup is always in the top left corner of the activity stream...

  • Position
  • Sidebar

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke

Copy link
Copy Markdown
Member

@nickvergessen What do you mean with sidebar?

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
Member Author

Activities in the sidebar of the file list didnt have it.
Fixed it with my last commit. Thanks for the help.

Ready to go?

@georgehrke

Copy link
Copy Markdown
Member

lgtm

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit b025b50 into master Apr 27, 2017
@nickvergessen nickvergessen deleted the contacts-popup branch April 27, 2017 14:15
@jancborchardt

Copy link
Copy Markdown
Member

@georgehrke I now added checkboxes to the server issue at nextcloud/server#4532 so you can check off when an app is fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants